Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wine Cellar #428

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Add Wine Cellar #428

merged 3 commits into from
Aug 29, 2023

Conversation

FlashyReese
Copy link
Contributor

Wine Cellar

This plugins add the functionality to manage Steam Play compatibility tools, allow users to download unofficial compatibility tools like Proton-GE, Luxtorpeda and etc.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • Yes: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.
  • Tested on SteamOS Preview Update Channel.

@FlashyReese FlashyReese requested a review from a team as a code owner August 25, 2023 20:06
@TrainDoctor TrainDoctor requested a review from a team August 25, 2023 21:37
@FlashyReese FlashyReese temporarily deployed to testing_env August 26, 2023 07:21 — with GitHub Actions Inactive
@PartyWumpus PartyWumpus self-assigned this Aug 28, 2023
PartyWumpus
PartyWumpus approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@PartyWumpus PartyWumpus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and it works great!
Small note: Maybe don't use the default icon here, currently it looks like this.
image
Maybe use FaWineGlass?
image

Also maybe remove the logo from the assets folder, as it's unused. I don't think it gets bundled if it's unused, but might as well.

nabel0
nabel0 approved these changes Aug 28, 2023
View reviewed changes
Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and is working fine on SteamOS Stable/Beta/Preview Update Channel.

@FlashyReese FlashyReese temporarily deployed to testing_env August 28, 2023 21:01 — with GitHub Actions Inactive
@FlashyReese
Copy link
Contributor Author

Code looks good and it works great! Small note: Maybe don't use the default icon here, currently it looks like this. image Maybe use FaWineGlass? image

Also maybe remove the logo from the assets folder, as it's unused. I don't think it gets bundled if it's unused, but might as well.

I have made suggested adjustments ended up using GiCellarBarrels instead
image

@TrainDoctor TrainDoctor merged commit c6ca017 into SteamDeckHomebrew:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabel0 nabel0 nabel0 approved these changes

@PartyWumpus PartyWumpus PartyWumpus approved these changes

@TrainDoctor TrainDoctor TrainDoctor approved these changes

Assignees

@FlashyReese FlashyReese

@PartyWumpus PartyWumpus

Labels
plugin-addition
Projects
SDH Tracker
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FlashyReese @TrainDoctor @PartyWumpus @nabel0